Skip to content

Conversation

prem-2006
Copy link

The lint_file() function previously stopped processing a line after detecting an opening or closing

tag due to 'continue' statements. This caused issues when a single line contained both
and
tags (e.g.,
Some Text
), resulting in an unbalanced block_context_stack.

This fix removes those 'continue' statements and allows both the opening and closing

tags to be processed within the same line. As a result, the RTL/LTR block context remains consistent and the linter no longer produces false positives or misses issues in subsequent lines.

What does this PR do?

Add resource(s) | Remove resource(s) | Add info | Improve repo

IMPORTANT

  • Read our contributing guidelines.
  • Is this a revision of a previously submitted PR? If so, STOP! Go back, reopen the PR, and add commit(s) the branch you previously submitted. Please don't make the job of reviewing more difficult by hiding previous work.

For resources

Description

Why is this valuable (or not)?

How do we know it's really free?

For book lists, is it a book? For course lists, is it a course? etc.

Checklist:

  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

The lint_file() function previously stopped processing a line after detecting
an opening or closing <div> tag due to 'continue' statements. This caused
issues when a single line contained both <div> and </div> tags (e.g.,
<div dir="rtl">Some Text</div>), resulting in an unbalanced block_context_stack.

This fix removes those 'continue' statements and allows both the opening and
closing <div> tags to be processed within the same line. As a result, the
RTL/LTR block context remains consistent and the linter no longer produces
false positives or misses issues in subsequent lines.
@Ajay-singh1
Copy link
Member

AI Generated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants