Replace paged with Prince #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 12, 2025
| "build-for-pdf": "ecmarkup --verbose spec.emu --printable --assets external out/index.html", | ||
| "pdf": "npm run build-for-pdf && pagedjs-cli --page-size a4 out/index.html -o out/index.pdf", | ||
| "build-for-pdf": "npm run prebuild-only && ecmarkup --verbose spec.emu out/index.html --assets external --assets-dir out --printable --lint-spec --strict", | ||
| "pdf": "npm run build-for-pdf && prince-books --script ./node_modules/ecmarkup/js/print.js out/index.html -o out/ECMA-CLE.pdf", |
Collaborator
There was a problem hiding this comment.
this change was added in #23, but prince-books doesn't seem to come from anywhere. is there a dependency missing?
Collaborator
There was a problem hiding this comment.
turns out this is not an npm dep, so it's fine
Collaborator
|
Covered by #23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.