Skip to content

Conversation

@SarahAlidoost
Copy link
Member

closes #65

@SarahAlidoost SarahAlidoost marked this pull request as ready for review December 9, 2024 15:23
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good.

It's a shame that there isn't an xarray config option. I did find this but it seems nothing came of it.

Maybe add the change to the changelog?

@sonarqubecloud
Copy link

@SarahAlidoost
Copy link
Member Author

Nice, looks good.

It's a shame that there isn't an xarray config option. I did find this but it seems nothing came of it.

Maybe add the change to the changelog?

Thanks for the review. I added changes to the changelog.

@SarahAlidoost SarahAlidoost merged commit 0af3c8c into main Dec 10, 2024
@SarahAlidoost SarahAlidoost deleted the fix_seg_err branch December 10, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segmentation fault error in tests

2 participants