CI test failure fix and replacement of poetry and mkapi by pixi and mkdocstrings#8
Merged
albop merged 15 commits intoEconForge:mainfrom Jun 26, 2025
Merged
CI test failure fix and replacement of poetry and mkapi by pixi and mkdocstrings#8albop merged 15 commits intoEconForge:mainfrom
albop merged 15 commits intoEconForge:mainfrom
Conversation
Member
|
Adding an underscore won't work since the class names are used to defined spécial type names in yaml. I had forgotten it.
Two possibilities :
- avoid importing *anything* from language.py <http://language.py>. this module has only side effets.
- find another workaround for the type system (like call it TMatrix and TVector...)
On Thu Jun 12, 2025, 04:19 PM GMT, ousema-bouaneni ***@***.***> wrote:
It turns out that the main problem was that I unknowingly deleted code from language.py that was used by dolang but seemed useless in the source code. I have rolled back these changes, and I am trying to figure out how to deal with the redefinitions of the Vector and Matrix types in language.py. As a temporary solution to prevent Mypy from complaining, I have added an underscore to distinguish them from the types I defined.
Otherwise, I modified the dependencies and added pull_request to the CI triggers so that a CI check is launched on each opened, reopened or synchronized pull request, so everything should work fine now 🤞 .
------------------------------
… You can view, comment on, or merge this pull request online at:
#8 <#8>
Commit Summary
- d13d13b <d13d13b> updated dependencies
- 72abaef <72abaef> replace typing.Self by typing_extensions.Self to keep python 3.10 support
- 7d0f06a <7d0f06a> rolled back changes that broke dolang
- c3675ce <c3675ce> reformatted with black
- ff588b7 <ff588b7> added pull requests to CI triggers
- adbaa8b <adbaa8b> Merge branch 'EconForge:main' into main
File Changes
(4 files <https://github.com/EconForge/dyno.py/pull/8/files>)
- M .github/workflows/ci.yaml <https://github.com/EconForge/dyno.py/pull/8/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133dd> (2)
- M dyno/language.py <https://github.com/EconForge/dyno.py/pull/8/files#diff-69819b84b9079cf316f3caa721506fe0c72ea9c8e4f644d5519d69cd99d89498> (18)
- M dyno/model.py <https://github.com/EconForge/dyno.py/pull/8/files#diff-77f3cad4e3a303380f8d4b2cf5d2a960ba51814e27ba4db03ca2e71d883490be> (3)
- M pyproject.toml <https://github.com/EconForge/dyno.py/pull/8/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711> (3)
Patch Links:
- https://github.com/EconForge/dyno.py/pull/8.patch <https://github.com/EconForge/dyno.py/pull/8.patch>
- https://github.com/EconForge/dyno.py/pull/8.diff <https://github.com/EconForge/dyno.py/pull/8.diff>
—
Reply to this email directly, view it on GitHub <#8>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACDSKMPMI5PPFAP5OW5FML3DGR7JAVCNFSM6AAAAAB7F4S6DOVHI2DSMVQWIX3LMV43ASLTON2WKOZTGE2DAOBZGAYDSNA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
created different environments in pixi to stop using poetry as dev environment, and replaced mkapi with mkdocstrings because of compatibility issues with pixi
Member
|
This looks good to me. I'll merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the main problem was that I unknowingly deleted code from
language.pythat was used bydolangbut seemed useless in the source code. I have rolled back these changes, and I am trying to figure out how to deal with the redefinitions of the Vector and Matrix types inlanguage.py. As a temporary solution to prevent Mypy from complaining, I have added an underscore to distinguish them from the types I defined.Otherwise, I modified the dependencies and added
pull_requestto the CI triggers so that a CI check is launched on each opened, reopened or synchronized pull request, so everything should work fine now 🤞 .