[DATASTD-2276] NuGet packaging for the Data Standard #348
Conversation
❌ XML Validation FailedXML validation found errors. Please review and fix the issues listed in the build log. Error FormatErrors are formatted as: Next Steps
|
1 similar comment
❌ XML Validation FailedXML validation found errors. Please review and fix the issues listed in the build log. Error FormatErrors are formatted as: Next Steps
|
| - name: Check if user has repository access | ||
| id: check-repo-access | ||
| uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1 | ||
| uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0 |
There was a problem hiding this comment.
Opportunistic updates
| defaults: | ||
| run: | ||
| working-directory: ./eng | ||
| working-directory: ./eng/xml-validator |
There was a problem hiding this comment.
Moved to a sub-directory so that the new NuGet packaging code can also be under /eng.
| <CodeValue>Little Shell Tribe </CodeValue> | ||
| <ShortDescription>Little Shell Tribe </ShortDescription> | ||
| <CodeValue>Little Shell Tribe</CodeValue> | ||
| <ShortDescription>Little Shell Tribe</ShortDescription> |
There was a problem hiding this comment.
At one point DMS rejected trailing spaces on property values. That may have been changed by now, but I went ahead and fixed these.
| /> | ||
| <None Include="../../Samples/Sample XML/Standards.xml" Pack="true" PackagePath="Partial\" /> | ||
| <None Include="../../Schemas/Bulk/*" Pack="true" PackagePath="XSD\" /> | ||
| <None Include="../../Schemas/OpenAPI/*" Pack="true" PackagePath="OpenAPI\" /> |
There was a problem hiding this comment.
Note that this already includes support for OpenAPI, even though the OpenAPI spec has not been included yet.
✅ XML Validation PassedAll XML files have been validated successfully against their schemas and descriptor definitions. |
✅ XML Validation PassedAll XML files have been validated successfully against their schemas and descriptor definitions. |
stephenfuqua
force-pushed
the
DATASTD-2276-v6
branch
from
66b31d9 to
d71ba80
Compare
✅ XML Validation PassedAll XML files have been validated successfully against their schemas and descriptor definitions. |
- Newer github/* versions - New directory for the xml-validator
Instead, just gitignore the sln file This reverts commit 8265d67.
stephenfuqua
force-pushed
the
DATASTD-2276-v6
branch
from
d71ba80 to
06223da
Compare
✅ XML Validation PassedAll XML files have been validated successfully against their schemas and descriptor definitions. |
✅ XML Validation PassedAll XML files have been validated successfully against their schemas and descriptor definitions. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces NuGet packaging support for the Ed-Fi Data Standard and restructures the XML validation tooling. The changes enable distribution of schema files and sample data as a NuGet package while organizing the XML validation scripts into a dedicated subdirectory.
- Adds NuGet packaging infrastructure with PowerShell scripts and C# project files
- Reorganizes XML validator into dedicated
eng/xml-validator/subdirectory with Poetry-based dependency management - Updates GitHub Actions workflows to reference actions by commit hash and adjust for new directory structure
- Adds test fixtures for XML validation testing
- Fixes trailing whitespace issues in descriptor files
Reviewed Changes
Copilot reviewed 8 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| eng/xml-validator/validate_xml.py | Updates path resolution to account for new nested directory structure |
| eng/xml-validator/pyproject.toml | Adds Poetry configuration for XML validator package dependencies |
| eng/xml-validator/README.md | Documents XML validation script usage and testing procedures |
| eng/xml-validator/testing/* | Adds XSD schemas and sample XML files for validation testing |
| eng/packaging/* | Adds NuGet packaging scripts, project configuration, and documentation |
| .github/workflows/*.yml | Updates workflows for new directory structure and action commit hashes |
| Descriptors/TribalAffiliationDescriptor.xml | Removes trailing whitespace from descriptor entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,32 @@ | |||
| # Ed-Fi Data Standard | |||
|
|
|||
| This pacakge contains XSD and OpenAPI specification files for the Ed-Fi Data | |||
There was a problem hiding this comment.
Corrected spelling of 'pacakge' to 'package'.
| This pacakge contains XSD and OpenAPI specification files for the Ed-Fi Data | |
| This package contains XSD and OpenAPI specification files for the Ed-Fi Data |
No description provided.