[AA-1808] Add dev Dockerfiles for MSSQL and PostgreSQL#523
[AA-1808] Add dev Dockerfiles for MSSQL and PostgreSQL#523roberthunterjr merged 10 commits intomainfrom
Conversation
…ations, and refine proxy settings in Nginx
Test Results84 tests 84 ✅ 0s ⏱️ Results for commit 8faa14f. ♻️ This comment has been updated with latest results. |
… container and improve logging
… for insecure connections
… update package dependencies
roberthunterjr
left a comment
roberthunterjr
left a comment
There was a problem hiding this comment.
How do we feel about git ignoring the dhparam.pem server.crt and server.key files to discourage reuse?
| API_INTERNAL_URL = http://${ODS_VIRTUAL_NAME} | ||
| ADMINAPP_HEALTHCHECK_TEST="curl -f http://${ADMINAPP_VIRTUAL_NAME}:8080/health" | ||
| API_HEALTHCHECK_TEST="curl -f http://localhost/health" | ||
| ADMINAPP_HEALTHCHECK_TEST="curl -kf https://localhost/${ADMINAPP_VIRTUAL_NAME}/health" |
There was a problem hiding this comment.
The -k is a nice touch here
@roberthunterjr I tried not to use them by creating a step to generate the certificate in the e2e test action, but it takes more than 5 minutes to get this only step done. So I kept the current approach we have in other repositories, reusing the certificate of the 'eng' folder. A similar approach is done in Admin API 2.X. https://github.com/Ed-Fi-Alliance-OSS/AdminAPI-2.x/blob/621678837035818e9d3c2568218c4f5cb12befe6/.github/workflows/api-e2e-pgsql-multitenant.yml#L53 |
3 participants
No description provided.