[CERT-210] On Pull Request workflows#74
Conversation
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| "private": true, | ||
| "version": "1.0.0", | ||
| "description": "Local dependencies for Tests Bruno collection (sandbox-safe).", | ||
| "license": "UNLICENSED", |
There was a problem hiding this comment.
Apache-2, although it is not very important to have that here.
| @@ -0,0 +1,179 @@ | |||
| # run-scenarios Script Usage | |||
There was a problem hiding this comment.
It looks like this script is connecting to api.ed-fi.org. That's OK in the short term, but in the longer term it might be better to start up the ODS/API containers to have a local copy.
FYI, @vimayya
There was a problem hiding this comment.
Correct me if I'm wrong, but I believe this is something @josephcampos-gap and @jpardogrowthaccelerationpartners have already starting looking at?
There was a problem hiding this comment.
Yes, but we haven't implemented anything yet... I do have it running locally for my local tests.
|
I love this PR's introduction of test automation, among other things. I hope this gets merged soon. |
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
* Rename to more universal `agents.md` * Standard markdown lint file * Update year and header * Issue management templates and workflow
d619df0 to
e813a3e
Compare
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
This pull request (previously PR #58 ) introduces significant improvements to CI/CD workflows, security scanning, dependency management, and test automation for the repository. It adds new GitHub Actions workflows for linting, QA scenario testing, and security/dependency analysis, refines configuration and ownership files, and improves test case parameterization for better clarity and maintainability.
CI/CD Workflow Enhancements
.github/workflows/on-pullrequest-lint-bruno.ymland.github/workflows/on-pullrequest-run-tests.ymlto automate Bruno linting and QA scenario testing on pull requests, with artifact upload and PR summary commenting. These workflows use pinned action versions for security and reliability. [1] [2] [3] [4].github/workflows/on-pullrequest.ymlto orchestrate BIDI Trojan scan, dependency review, and CodeQL analysis on PRs and pushes.Security and Dependency Management
.github/workflows/bidi-config.jsonfor configuring BIDI Trojan file exclusions..github/dependabot.ymlto enable automated npm dependency updates for both the root andbrunodirectories..codeql-config.ymlto exclude test, build, and dependency directories from CodeQL analysis for more focused security scans.Documentation and Ownership
.github/TESTING_ACTIONS_LOCALLY.mdwith detailed instructions for local testing of GitHub Actions workflows usingact..github/CODEOWNERSto assign ownership of all.githubfiles to the appropriate team.Test Case Improvements
[ENTER_SCHOOL_ID]) instead of hardcoded IDs, improving test reusability and clarity. [1] [2] [3] [4]bruno/SIS/v4/MasterSchedule/BellSchedules/folder.brufor improved documentation readability.