[CERT-212] Scenarios CONDITIONALs as REQUIRED#92
Merged
josephcampos-gap merged 3 commits intomainfrom Dec 24, 2025
Merged
Conversation
Bruno Lint ReportFiles Scanned: 331 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
23d11c4 to
5424ad8
Compare
Bruno Lint ReportFiles Scanned: 331 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
jpardogrowthaccelerationpartners
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the SIS test suite and its supporting documentation, primarily focusing on aligning assertion logic with updated requirements for field necessity (REQUIRED, CONDITIONAL, OPTIONAL). It removes some legacy test files, updates assertion patterns in multiple test cases, and revises the documentation to clarify and enforce how CONDITIONAL fields should be handled (asserted like REQUIRED fields). The changes improve test coverage, accuracy, and maintainability.
Test Assertion Updates:
shortNameOfInstitutionin school tests,gradeLevelDescriptorin calendar tests,electronicMailTypeDescriptorandbirthDatein staff tests, and several others. This ensures that these fields are always asserted for presence and correct type. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Documentation and Specification Alignment:
bruno/ai-docs/spec.mdto clarify that CONDITIONAL fields are asserted in the same way as REQUIRED fields, including updates to assertion patterns, collection handling, and logging rules. This brings the documentation in line with the new assertion logic in the test cases. [1] [2] [3] [4] [5] [6] [7] [8] [9]Test Suite Cleanup:
bruno/SIS/Fetch Datadirectory, including01 - Fetch School.bru,02 - Fetch Calendar.bru, andfolder.bru, to streamline the test suite and avoid confusion with updated scenarios. [1] [2] [3]Miscellaneous:
bruno/SIS/v4/folder.bruto reflect the current order of test execution.