Skip to content

[CERT-212] Scenarios CONDITIONALs as REQUIRED#92

Merged
josephcampos-gap merged 3 commits intomainfrom
CERT-212
Dec 24, 2025
Merged

[CERT-212] Scenarios CONDITIONALs as REQUIRED#92
josephcampos-gap merged 3 commits intomainfrom
CERT-212

Conversation

@josephcampos-gap
Copy link
Contributor

This pull request makes several updates to the SIS test suite and its supporting documentation, primarily focusing on aligning assertion logic with updated requirements for field necessity (REQUIRED, CONDITIONAL, OPTIONAL). It removes some legacy test files, updates assertion patterns in multiple test cases, and revises the documentation to clarify and enforce how CONDITIONAL fields should be handled (asserted like REQUIRED fields). The changes improve test coverage, accuracy, and maintainability.

Test Assertion Updates:

  • Updated assertion logic in test cases to add or strengthen checks for fields marked as REQUIRED or CONDITIONAL, such as shortNameOfInstitution in school tests, gradeLevelDescriptor in calendar tests, electronicMailTypeDescriptor and birthDate in staff tests, and several others. This ensures that these fields are always asserted for presence and correct type. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]

Documentation and Specification Alignment:

  • Revised bruno/ai-docs/spec.md to clarify that CONDITIONAL fields are asserted in the same way as REQUIRED fields, including updates to assertion patterns, collection handling, and logging rules. This brings the documentation in line with the new assertion logic in the test cases. [1] [2] [3] [4] [5] [6] [7] [8] [9]

Test Suite Cleanup:

  • Removed legacy or redundant test files from the bruno/SIS/Fetch Data directory, including 01 - Fetch School.bru, 02 - Fetch Calendar.bru, and folder.bru, to streamline the test suite and avoid confusion with updated scenarios. [1] [2] [3]

Miscellaneous:

  • Updated the sequence number in bruno/SIS/v4/folder.bru to reflect the current order of test execution.

@github-actions
Copy link

Bruno Lint Report

Files Scanned: 331
Problems: 0 (Errors: 0, Warnings: 0)
✅ No blocking errors.

Triggered by workflow: lint-bruno.yml

@github-actions
Copy link

QA Scenarios Summary

Status: PASS
Entities Processed: 1
Assertions: Passed 19, Failed 0, Total 19

Entity Passed Failed Total
BellSchedules 19 0 19

@github-actions
Copy link

Bruno Lint Report

Files Scanned: 331
Problems: 0 (Errors: 0, Warnings: 0)
✅ No blocking errors.

Triggered by workflow: lint-bruno.yml

@github-actions
Copy link

QA Scenarios Summary

Status: PASS
Entities Processed: 1
Assertions: Passed 19, Failed 0, Total 19

Entity Passed Failed Total
BellSchedules 19 0 19

@josephcampos-gap josephcampos-gap merged commit 64d8944 into main Dec 24, 2025
8 checks passed
@josephcampos-gap josephcampos-gap deleted the CERT-212 branch December 24, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants