[CERT-193] fix: Fixes to match the data model#96
Merged
jpardogrowthaccelerationpartners merged 1 commit intomainfrom Dec 24, 2025
Merged
[CERT-193] fix: Fixes to match the data model#96jpardogrowthaccelerationpartners merged 1 commit intomainfrom
jpardogrowthaccelerationpartners merged 1 commit intomainfrom
Conversation
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
josephcampos-gap
changed the title
josephcampos-gap
force-pushed
the
CERT-193-bugfix-1
branch
from
cc260e1 to
1b6e89b
Compare
Bruno Lint ReportFiles Scanned: 334 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
josephcampos-gap
force-pushed
the
CERT-193-bugfix-1
branch
from
1b6e89b to
15cb0d0
Compare
Bruno Lint ReportFiles Scanned: 331 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
jpardogrowthaccelerationpartners
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the validation and documentation for the
StudentDisciplineIncidentBehaviorAssociationsentity to better align with the actual API model. The main changes involve replacing the deprecatedstudentParticipationCodeDescriptorfield with the correctdisciplineIncidentParticipationCodesstructure and updating documentation and tests accordingly. A new TODO file is also added to track documentation corrections that are still pending in the official Ed-Fi API docs.Validation and Test Updates:
01 - Check first StudDisciplineIncidentBehaviorAssocs is valid.bruand02 - Check second StudDisciplineIncidentBehaviorAssocs is valid.bruto validate the newdisciplineIncidentParticipationCodesarray and its descriptor, removing checks for the obsoletestudentParticipationCodeDescriptorfield. [1] [2]Documentation Updates:
folder.brudocumentation to:behaviorsandstudentParticipationCodeDescriptorfields, which do not exist in the model.disciplineIncidentParticipationCodesarray and its descriptor as required fields, reflecting the actual API response.Process and Tracking:
todo.mdfile outlining the documentation issues and the steps needed to align the official Ed-Fi API documentation with the actual API model, including a checklist of corrections made and pending.