Skip to content

[CERT-190] fix: improved and removed validations#99

Merged
jpardogrowthaccelerationpartners merged 1 commit intomainfrom
CERT-190-bugfix
Dec 24, 2025
Merged

[CERT-190] fix: improved and removed validations#99
jpardogrowthaccelerationpartners merged 1 commit intomainfrom
CERT-190-bugfix

Conversation

@josephcampos-gap
Copy link
Contributor

This pull request updates validation logic and documentation for student academic records to use reference objects instead of direct property fields, and improves numeric field assertions. It also removes graduation plan field checks from both validation and documentation to align with updated data structures.

Validation logic updates:

  • Updated assertions in 01 - Check first StudentAcademicRecord is valid.bru, 02 - Check second StudentAcademicRecord is valid.bru, and 03 - Check second StudentAcademicRecord cumulativeAttemptedCredits, cumulativeEarnedCredits and sessionEarnedCredits was Updated.bru to:
    • Use nested reference objects (educationOrganizationReference, schoolYearTypeReference, studentReference) instead of direct fields for organization, school year, and student identifiers. [1] [2] bruno/SIS/v4/StudentTranscript/StudentAcademicRecords/03 - Check second StudentAcademicRecord cumulativeAttemptedCredits, cumulativeEarnedCredits and sessionEarnedCredits was Updated.bruL17-R32)
    • Change numeric assertions for credit and GPA fields from type checks (e.g., isNumber) to value checks (gte 0), ensuring these values are non-negative. [1] [2] bruno/SIS/v4/StudentTranscript/StudentAcademicRecords/03 - Check second StudentAcademicRecord cumulativeAttemptedCredits, cumulativeEarnedCredits and sessionEarnedCredits was Updated.bruL17-R32)
    • Remove validation for graduationPlans fields in the second student academic record.

Documentation updates:

  • Removed documentation for graduationPlans fields (educationOrganizationId, graduationSchoolYear, graduationPlanTypeDescriptor) from folder.bru to reflect the updated data structure and validation logic.

@github-actions
Copy link

Bruno Lint Report

Files Scanned: 331
Problems: 0 (Errors: 0, Warnings: 0)
✅ No blocking errors.

Triggered by workflow: lint-bruno.yml

@github-actions
Copy link

QA Scenarios Summary

Status: PASS
Entities Processed: 1
Assertions: Passed 19, Failed 0, Total 19

Entity Passed Failed Total
BellSchedules 19 0 19

@jpardogrowthaccelerationpartners jpardogrowthaccelerationpartners merged commit be7aca3 into main Dec 24, 2025
8 checks passed
@jpardogrowthaccelerationpartners jpardogrowthaccelerationpartners deleted the CERT-190-bugfix branch December 24, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants