[CERT-190] fix: improved and removed validations#99
Merged
jpardogrowthaccelerationpartners merged 1 commit intomainfrom Dec 24, 2025
Merged
[CERT-190] fix: improved and removed validations#99jpardogrowthaccelerationpartners merged 1 commit intomainfrom
jpardogrowthaccelerationpartners merged 1 commit intomainfrom
Conversation
Bruno Lint ReportFiles Scanned: 331 Triggered by workflow: lint-bruno.yml |
QA Scenarios SummaryStatus: PASS
|
jpardogrowthaccelerationpartners
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates validation logic and documentation for student academic records to use reference objects instead of direct property fields, and improves numeric field assertions. It also removes graduation plan field checks from both validation and documentation to align with updated data structures.
Validation logic updates:
01 - Check first StudentAcademicRecord is valid.bru,02 - Check second StudentAcademicRecord is valid.bru, and03 - Check second StudentAcademicRecord cumulativeAttemptedCredits, cumulativeEarnedCredits and sessionEarnedCredits was Updated.bruto:educationOrganizationReference,schoolYearTypeReference,studentReference) instead of direct fields for organization, school year, and student identifiers. [1] [2] bruno/SIS/v4/StudentTranscript/StudentAcademicRecords/03 - Check second StudentAcademicRecord cumulativeAttemptedCredits, cumulativeEarnedCredits and sessionEarnedCredits was Updated.bruL17-R32)isNumber) to value checks (gte 0), ensuring these values are non-negative. [1] [2] bruno/SIS/v4/StudentTranscript/StudentAcademicRecords/03 - Check second StudentAcademicRecord cumulativeAttemptedCredits, cumulativeEarnedCredits and sessionEarnedCredits was Updated.bruL17-R32)graduationPlansfields in the second student academic record.Documentation updates:
graduationPlansfields (educationOrganizationId,graduationSchoolYear,graduationPlanTypeDescriptor) fromfolder.bruto reflect the updated data structure and validation logic.