Expose more configuration and result properties to ML Kit's face detection #704

Author: EddyVerbruggen

src/mlkit/facedetection/index.android.ts

@@ -54,8 +54,8 @@ function getFaceDetector(options: MLKitDetectFacesOnDeviceOptions): any {
   const faceDetectorOptions =
       new com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.Builder()
           .setModeType(options.detectionMode === "accurate" ? com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.ACCURATE_MODE : com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.FAST_MODE)
-          // .setLandmarkType(com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.ALL_LANDMARKS) // TODO
-          // .setClassificationType(com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.ALL_CLASSIFICATIONS) // TODO
+          .setLandmarkType(com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.ALL_LANDMARKS) // TODO make configurable
+          .setClassificationType(com.google.firebase.ml.vision.face.FirebaseVisionFaceDetectorOptions.ALL_CLASSIFICATIONS) // TODO make configurable
           .setMinFaceSize(options.minimumFaceSize)
           .setTrackingEnabled(options.enableFaceTracking === true)
           .build();

src/mlkit/facedetection/index.ios.ts

@@ -62,8 +62,8 @@ function getDetector(options: MLKitDetectFacesOnDeviceOptions): FIRVisionFaceDet
   const firVision: FIRVision = FIRVision.vision();
   const firOptions = FIRVisionFaceDetectorOptions.new();
   firOptions.modeType = options.detectionMode === "accurate" ? FIRVisionFaceDetectorMode.Accurate : FIRVisionFaceDetectorMode.Fast;
-  // firOptions.landmarkType = FIRVisionFaceDetectorLandmark.All; // TODO
-  // firOptions.classificationType = FIRVisionFaceDetectorClassification.All; // TODO
+  firOptions.landmarkType = FIRVisionFaceDetectorLandmark.All; // TODO make configurable
+  firOptions.classificationType = FIRVisionFaceDetectorClassification.All; // TODO make configurable
   firOptions.minFaceSize = options.minimumFaceSize;
   firOptions.isTrackingEnabled = options.enableFaceTracking === true;
   return firVision.faceDetectorWithOptions(firOptions);