Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit e7ed8b6

Browse files
Removing listeners through the Web API failed partially.
1 parent 2c827a5 commit e7ed8b6

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

src/app/database/index.ts

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export module database {
4747
if (!Query.registeredListeners.has(this.path)) {
4848
Query.registeredListeners.set(this.path, []);
4949
}
50-
Query.registeredListeners.get(this.path).push(result.listeners);
50+
Query.registeredListeners.set(this.path, Query.registeredListeners.get(this.path).concat(result.listeners));
5151
},
5252
error => {
5353
console.log("firebase.database().on error: " + error);
@@ -64,19 +64,10 @@ export module database {
6464
}
6565

6666
public off(eventType? /* TODO use */: string, callback?: (a: DataSnapshot, b?: string | null) => any, context?: Object | null): any {
67-
console.log("firebase.database().off: " + eventType);
68-
console.log("firebase.database().off this.registeredListeners: " + Query.registeredListeners);
69-
console.log("firebase.database().off this.path: " + this.path);
7067
if (Query.registeredListeners.has(this.path)) {
71-
console.log("firebase.database().off !has");
7268
firebase.removeEventListeners(Query.registeredListeners.get(this.path), this.path).then(
73-
result => {
74-
Query.registeredListeners.delete(this.path);
75-
console.log("firebase.database().off success");
76-
},
77-
error => {
78-
console.log("firebase.database().off error: " + error);
79-
}
69+
result => Query.registeredListeners.delete(this.path),
70+
error => console.log("firebase.database().off error: " + error)
8071
);
8172
}
8273
Query.registeredCallbacks.delete(this.path);

src/mlkit/imagelabeling/index.android.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ export function labelImageOnDevice(options: MLKitImageLabelingOnDeviceOptions):
7373
});
7474
}
7575

76-
console.log(">>> image labeling result: " + JSON.stringify(result));
7776
resolve(result);
7877
firebaseVisionLabelDetector.close();
7978
}
@@ -120,7 +119,6 @@ export function labelImageCloud(options: MLKitImageLabelingCloudOptions): Promis
120119
});
121120
}
122121

123-
console.log(">>> cloud image labeling result: " + JSON.stringify(result));
124122
resolve(result);
125123
firebaseVisionCloudLabelDetector.close();
126124
}

0 commit comments

Comments
 (0)