Crash reporting slows startup time #240

Author: EddyVerbruggen

docs/CRASHREPORTING.md

@@ -3,8 +3,9 @@
 <img src="images/features/crash.png" width="296px" height="124px" alt="Crash"/>
 
 ## Enabling Crash Reporting
-Nothing to do - since plugin version 3.8.2 this plugin automatically uploads
-crashes to your Firebase Console. Just check the 'Crash' menu item every now and then.
+With plugin version 3.9.0+ you will be prompted during installation of the plugin to enable Crash Reporting (it's off by default).
+
+In older versions it was on by default but it may slow down app startup a bit so now it's disabled by default.
 
 ## Making sense of the stacktraces
 Please read [the official docs](https://firebase.google.com/docs/crash/)

platforms/android/include.gradle

@@ -17,7 +17,6 @@ dependencies {
     compile "com.google.firebase:firebase-core:10.0.+"
     compile "com.google.firebase:firebase-database:10.0.+"
     compile "com.google.firebase:firebase-auth:10.0.+"
-    compile "com.google.firebase:firebase-crash:10.0.+"
 
     // for reading google-services.json and configuration
     def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : '10.0.+'
@@ -26,6 +25,9 @@ dependencies {
     // Uncomment if you want to use 'Remote Config'
 //    compile "com.google.firebase:firebase-config:10.0.+"
 
+    // Uncomment if you want to use 'Crash Reporting'
+//    compile "com.google.firebase:firebase-crash:10.0.+"
+
     // Uncomment if you want FCM (Firebase Cloud Messaging)
 //    compile "com.google.firebase:firebase-messaging:10.0.+"
 

platforms/ios/Podfile

@@ -2,11 +2,13 @@
 pod 'Firebase', '~> 3.11.0'
 pod 'Firebase/Database'
 pod 'Firebase/Auth'
-pod 'Firebase/Crash'
 
 # Uncomment if you want to enable Remote Config
 #pod 'Firebase/RemoteConfig'
 
+# Uncomment if you want to enable Crash Reporting
+#pod 'Firebase/Crash'
+
 # Uncomment if you want to enable FCM (Firebase Cloud Messaging)
 #pod 'Firebase/Messaging'
 

scripts/installer.js

@@ -110,6 +110,10 @@ function promptQuestions() {
         name: 'messaging',
         description: 'Are you using Firebase Messaging (y/n)',
         default: 'n'
+    }, {
+        name: 'crash_reporting',
+        description: 'Are you using Firebase Crash Reporting (y/n)',
+        default: 'n'
     }, {
         name: 'storage',
         description: 'Are you using Firebase Storage (y/n)',
@@ -194,11 +198,13 @@ function writePodFile(result) {
 `pod 'Firebase', '~> 3.11.0'
 pod 'Firebase/Database'
 pod 'Firebase/Auth'
-pod 'Firebase/Crash'
 
 # Uncomment if you want to enable Remote Config
 ` + (isSelected(result.remote_config) ? `` : `#`) + `pod 'Firebase/RemoteConfig'
 
+# Uncomment if you want to enable Crash Reporting
+` + (isSelected(result.crash_reporting) ? `` : `#`) + `pod 'Firebase/Crash'
+
 # Uncomment if you want to enable FCM (Firebase Cloud Messaging)
 ` + (isSelected(result.messaging) ? `` : `#`) + `pod 'Firebase/Messaging'
 
@@ -248,7 +254,6 @@ dependencies {
     compile "com.google.firebase:firebase-core:10.0.+"
     compile "com.google.firebase:firebase-database:10.0.+"
     compile "com.google.firebase:firebase-auth:10.0.+"
-    compile "com.google.firebase:firebase-crash:10.0.+"
 
     // for reading google-services.json and configuration
     def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : '10.0.+'
@@ -257,6 +262,9 @@ dependencies {
     // Uncomment if you want to use 'Remote Config'
     ` + (isSelected(result.remote_config) ? `` : `//`) + ` compile "com.google.firebase:firebase-config:10.0.+"
 
+    // Uncomment if you want to use 'Crash Reporting'
+    ` + (isSelected(result.crash_reporting) ? `` : `//`) + ` compile "com.google.firebase:firebase-crash:10.0.+"
+
     // Uncomment if you want FCM (Firebase Cloud Messaging)
     ` + (isSelected(result.messaging) ? `` : `//`) + ` compile "com.google.firebase:firebase-messaging:10.0.+"
 

scripts/postinstall.js

@@ -2906,6 +2906,10 @@ function promptQuestions() {
         name: 'messaging',
         description: 'Are you using Firebase Messaging (y/n)',
         default: 'n'
+    }, {
+        name: 'crash_reporting',
+        description: 'Are you using Firebase Crash Reporting (y/n)',
+        default: 'n'
     }, {
         name: 'storage',
         description: 'Are you using Firebase Storage (y/n)',
@@ -2990,11 +2994,13 @@ function writePodFile(result) {
 `pod 'Firebase', '~> 3.11.0'
 pod 'Firebase/Database'
 pod 'Firebase/Auth'
-pod 'Firebase/Crash'
 
 # Uncomment if you want to enable Remote Config
 ` + (isSelected(result.remote_config) ? `` : `#`) + `pod 'Firebase/RemoteConfig'
 
+# Uncomment if you want to enable Crash Reporting
+` + (isSelected(result.crash_reporting) ? `` : `#`) + `pod 'Firebase/Crash'
+
 # Uncomment if you want to enable FCM (Firebase Cloud Messaging)
 ` + (isSelected(result.messaging) ? `` : `#`) + `pod 'Firebase/Messaging'
 
@@ -3044,7 +3050,6 @@ dependencies {
     compile "com.google.firebase:firebase-core:10.0.+"
     compile "com.google.firebase:firebase-database:10.0.+"
     compile "com.google.firebase:firebase-auth:10.0.+"
-    compile "com.google.firebase:firebase-crash:10.0.+"
 
     // for reading google-services.json and configuration
     def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : '10.0.+'
@@ -3053,6 +3058,9 @@ dependencies {
     // Uncomment if you want to use 'Remote Config'
     ` + (isSelected(result.remote_config) ? `` : `//`) + ` compile "com.google.firebase:firebase-config:10.0.+"
 
+    // Uncomment if you want to use 'Crash Reporting'
+    ` + (isSelected(result.crash_reporting) ? `` : `//`) + ` compile "com.google.firebase:firebase-crash:10.0.+"
+
     // Uncomment if you want FCM (Firebase Cloud Messaging)
     ` + (isSelected(result.messaging) ? `` : `//`) + ` compile "com.google.firebase:firebase-messaging:10.0.+"