Matthias/refactoring rkpm weak dirichlet locations#3
Merged
maderthomas merged 17 commits intomasterfrom Nov 11, 2025
Merged
Conversation
…k_dirichlet_locations
There was a problem hiding this comment.
Pull Request Overview
This PR updates numerical parameters and test configurations across multiple test examples to enable line search functionality and improve convergence. Key changes include adjusting solver tolerances, iteration limits, and time step sizes, along with updating gold standard results to reflect these modifications.
Key Changes:
- Added line search parameters to the quadratic line search test with specific iteration thresholds
- Modified iteration options from legacy parameters to tolerance-based configurations in several tests
- Updated test tolerance levels from strict (1e-12) to more relaxed values (1e-7, 1e-8) for several tests
- Changed exception handling in dirichlet_load_test from ValueError to NotImplementedError
Reviewed Changes
Copilot reviewed 39 out of 89 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/123_quadratic_line_search_test/quadratic_line_search_test.py | Added line search configuration, adjusted time step and iteration parameters |
| examples/123_quadratic_line_search_test/gold.csv | New gold standard results for quadratic line search test |
| examples/122_lagrangian_multiplier_equal_value_test/* | New test files for Lagrangian multiplier equal value constraints |
| examples/121_marmot_r-snni-finite_strain_plasticity_test/gold.csv | Removed old gold standard results |
| examples/120_lagrangian_multiplier_bc_test/* | Updated material parameters and iteration options, relaxed test tolerance |
| examples/119_marmot_micropolar_sqcni_sdi_vci_dynamic_test/* | Changed particle element type reference, regenerated gold results |
| examples/118_marmot_micropolar_sqcni_nsni_vci_dynamic_test/* | Updated iteration options to tolerance-based config, relaxed test tolerance |
| examples/117_marmot_micropolar_sqcni_sdi_vci_order_1_test/* | Changed particle element type, updated iteration config and test tolerance |
| examples/117_marmot_micropolar_sqcni_sdi_test/* | Changed particle element type reference, regenerated gold results |
| examples/117_marmot_micropolar_sqcni__snsni_test/ | New test files for various micropolar formulations |
| examples/006_dirichlet_load/dirichlet_load_test.py | Changed exception type from ValueError to NotImplementedError |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+133
to
+137
| # if self._constrainedLocation == "center": | ||
| # constrainedCoordinates = p.getCenterCoordinates() | ||
| # elif isinstance(self._constrainedLocation, int): | ||
| # constrainedCoordinates = p.getVertexCoordinates()[self._constrainedLocation] | ||
|
|
There was a problem hiding this comment.
This comment appears to contain commented-out code.
Suggested change
| # if self._constrainedLocation == "center": | |
| # constrainedCoordinates = p.getCenterCoordinates() | |
| # elif isinstance(self._constrainedLocation, int): | |
| # constrainedCoordinates = p.getVertexCoordinates()[self._constrainedLocation] |
matthiasneuner
deleted the
matthias/refactoring_rkpm_weak_dirichlet_locations
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.