Safe splitting #694
Merged
Safe splitting #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/safe-splitting
branch
from
97c6f6a to
a3f4bf1
Compare
samholmes
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Consider adding a changelog entry for this fix as well. The current changelog only mentions the duplicate sync keys fix but not the preservation of migratedFromWalletId during wallet re-split.
swansontec
force-pushed
the
william/safe-splitting
branch
from
a3f4bf1 to
b8995f7
Compare
swansontec
force-pushed
the
william/safe-splitting
branch
from
b8995f7 to
9f060db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none