Open
Conversation
| if (apiKey == null) { | ||
| const cleanKey = asEthereumInitKeys(key) | ||
| const cleanApiKey = this.ethEngine.initOptions[cleanKey] | ||
| if (cleanApiKey === 'string') { |
There was a problem hiding this comment.
Bug: Type check uses value comparison instead of typeof
The addRpcApiKey function's fallback for deprecated API keys incorrectly checks cleanApiKey === 'string' instead of typeof cleanApiKey === 'string'. This prevents the fallback from working, leading to "Missing serviceKeys" errors for users relying on deprecated initOptions like infuraProjectId.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
noneNote
Adds centralized serviceKeys for API keys and updates Ethereum tools/adapters/fees to use them with deprecation fallbacks.
ServiceKeystype and cleaner insrc/common/types.tsand new helpersgetRandomServiceKey/getServiceKeyIndexinsrc/common/serviceKeys.ts.EthereumInitOptionswithserviceKeys(andinfuraProjectId), mark legacy keys (e.g.,etherscanApiKey,evmScanApiKey,amberdataApiKey, etc.) as deprecated viaasEthereumInitOptions.asEthereumInitOptionsinEthereumTools.getEvmScanApiKeyto preferserviceKeys(by host viagetServiceKeyIndex), fallback to deprecated keys with warnings.serviceKeyswith fallbacks inAmberdataAdapter,BlockchairAdapter,BlockcypherAdapter,BlockbookWsAdapter, andRpcAdapter(including RPC URL template key replacement and error messaging).feeProvider.test.tsto supplyserviceKeysfor EvmScan test.Written by Cursor Bugbot for commit 80e245e. This will update automatically on new commits. Configure here.