Merged
Conversation
samholmes
force-pushed
the
sam/simplify-saves
branch
2 times, most recently
from
8e2c5b0 to
108138a
Compare
peachbits
requested changes
Mar 31, 2025
src/MoneroEngine.ts
Outdated
|
|
||
| // Already have this tx in the database. Consider a change if blockHeight changed | ||
| if (edgeTx.blockHeight === edgeTransaction.blockHeight) return | ||
| this.log(`Update transaction: ${edgeTx.txid} height:${edgeTx.blockHeight}`) |
Collaborator
There was a problem hiding this comment.
Should be logging edgeTransaction.blockHeight
samholmes
force-pushed
the
sam/simplify-saves
branch
from
108138a to
2ed33da
Compare
The purpose of this is to avoid the foot-gun: calling `addTransaction` when the transaction exists in the database will result in `updateTransaction` being invoked without the Monero specific tx update logic.
samholmes
force-pushed
the
sam/simplify-saves
branch
from
2ed33da to
683fab9
Compare
peachbits
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none