Translate spend errors from lib to InsufficientFundsError

[samholmes]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

none

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1210488506598606

[swansontec]

This should be catch (error: unknown), and then use if (error instanceof Error) prior to accessing error.message. Since the error instanceof Error check takes us back into type-land, we can also do error.message === 'Not enough spendables' instead of using cleaners - that's a valid property access at that point. Something more like this:

try {
} catch (error: unknown) {
  if (!(error instanceof error)) {
    throw new Error(String(error))
  }

  if (error.message === 'Not enough spendables') {
    throw new InsufficientFundsError({
        tokenId: PRIMARY_CURRENCY_TOKEN_ID
      })
  }

   const regex = / Have (\d*\.?\d+) XMR; need (\d*\.?\d+) XMR./gm
   const subst = `\nHave: $1 XMR.\nNeed: $2 XMR.`
   const msgFormatted = error.message.replace(regex, subst)
   throw new Error(msgFormatted)
 }

Also, isn't the "Have: $1 XMR.\nNeed: $2 XMR" error another case of insufficient funds?