Paul/v2converter by paullinator · Pull Request #119 · EdgeApp/edge-rates-server

paullinator · 2025-10-26T02:01:48Z

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

Yes
No

Dependencies

none

Description

none

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1211748799462297

src/v3/types.ts

peachbits · 2025-10-30T07:37:47Z

src/v3/v2converter.ts

+  // Helper to add crypto asset
+  const addCrypto = (currencyCode: string, date: Date): void => {
+    const asset = currencyCodeToAsset(currencyCode, currencyCodeMaps)
+    const key = `${asset.pluginId}_${


Use toCryptoKey util

I can't because the key needs to include the date. Parsing would break with toCryptoKey since it doesn't put an _null for null tokenIds which would be hard to parse if I tack an _[date] at the end of it.

I mentioned the wrong util. There's toDatedCryptoKey (and toDatedFiatKey) hiding in the src/v3/router file instead of utils. For the very issue you mentioned it puts the date in the front

src/v3/v2converter.ts

peachbits · 2025-10-30T07:58:20Z

src/v3/indexEngines.ts

 ): Promise<void> => {
-  const delayMs = frequencyToMs[frequency]
+  const delayMs =
+    typeof frequency === 'number' ? frequency * 1000 : frequencyToMs[frequency]


Use the frequency as-is without multiplying by 1000

The frequency value is specified in seconds not ms.

The function treats it as seconds but it isn't specified as such. This could be typed instead as

type Frequency = 'minute' | 'hour' | 'day' | 'week' | 'month' type FrequencySeconds = number

then the definition becomes:

const createEngineLoop = async ( providerId: string, engine: RateEngine, frequency: Frequency | FrequencySeconds ): Promise<void> => { ): Promise<void> => {

peachbits · 2025-10-30T07:59:32Z

src/v3/providers/coingecko/coingecko.ts

      engine: tokenMapping
+    },
+    {
+      frequency: 120,


hence why the engine multiplies by 1000. anything less than 1 sec is worthless as a frequency

I understand why you used seconds here. I'm suggesting to pass ms here because I think the createEngineLoop definition is ambiguous. If you make the suggested type change then this comment is no longer relevant

src/providers/coingecko.ts

peachbits · 2025-11-04T22:01:05Z

src/v3/indexEngines.ts

 ): Promise<void> => {
-  const delayMs = frequencyToMs[frequency]
+  const delayMs =
+    typeof frequency === 'number' ? frequency * 1000 : frequencyToMs[frequency]


The function treats it as seconds but it isn't specified as such. This could be typed instead as

type Frequency = 'minute' | 'hour' | 'day' | 'week' | 'month' type FrequencySeconds = number

then the definition becomes:

const createEngineLoop = async ( providerId: string, engine: RateEngine, frequency: Frequency | FrequencySeconds ): Promise<void> => { ): Promise<void> => {

peachbits · 2025-11-04T22:11:35Z

src/v3/providers/coingecko/coingecko.ts

      engine: tokenMapping
+    },
+    {
+      frequency: 120,


I understand why you used seconds here. I'm suggesting to pass ms here because I think the createEngineLoop definition is ambiguous. If you make the suggested type change then this comment is no longer relevant

peachbits · 2025-11-04T22:25:00Z

src/v3/v2converter.ts

+  // Helper to add crypto asset
+  const addCrypto = (currencyCode: string, date: Date): void => {
+    const asset = currencyCodeToAsset(currencyCode, currencyCodeMaps)
+    const key = `${asset.pluginId}_${


I mentioned the wrong util. There's toDatedCryptoKey (and toDatedFiatKey) hiding in the src/v3/router file instead of utils. For the very issue you mentioned it puts the date in the front

v2 requests into converter MUST have dates

paullinator force-pushed the paul/v2converter branch 5 times, most recently from 1aa450a to be885c9 Compare October 30, 2025 01:03

peachbits requested changes Oct 30, 2025

View reviewed changes

paullinator force-pushed the paul/v2converter branch from be885c9 to bdf5016 Compare October 30, 2025 21:27

peachbits requested changes Nov 4, 2025

View reviewed changes

paullinator force-pushed the paul/v2converter branch from bdf5016 to 523b059 Compare November 20, 2025 02:41

peachbits approved these changes Dec 2, 2025

View reviewed changes

paullinator added 8 commits December 2, 2025 14:12

Add v2>v3 route converter

2a80b7d

Allow engines to specify frequency in seconds

e76d5a2

Add coinrank v2 endpoint

837ee0e

Add v2/coinrankAsset support

60e2e22

Refactor coingeckoAssets to be able to get raw response

ba25420

Add legacy v2/coinrankList endpoint

2d2b12f

Allow cors

13333e7

Fix failing test

d1f284c

v2 requests into converter MUST have dates

peachbits force-pushed the paul/v2converter branch from 523b059 to d1f284c Compare December 2, 2025 22:12

peachbits merged commit c2766d5 into master Dec 2, 2025
1 check passed

Conversation

paullinator commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CHANGELOG

Dependencies

Description

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

paullinator commented Oct 26, 2025 •

edited

Loading