Skip to content

zcoin sigma integration#2075

Closed
hzak wants to merge 1 commit intoEdgeApp:developfrom
hzak:integrate-zcoin-sigma
Closed

zcoin sigma integration#2075
hzak wants to merge 1 commit intoEdgeApp:developfrom
hzak:integrate-zcoin-sigma

Conversation

@hzak
Copy link
Copy Markdown

@hzak hzak commented Jun 27, 2020

Pull request contains zcoin sigma module integration. PR for the currency changes is here.

PR Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS Tablet
  • Tested on small Android
  • n/a

Comment on lines +87 to +89
if (tx.otherParams.isSpecialTransaction) {
txName = getSpecialCurrencyInfo(this.props.selectedCurrencyCode).specialTransactionTitle
}
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 94

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tx.otherParams.needCustomTxTitle

showEarnInterestCard: true
},
XZC: {
specialTransactionTitle: s.strings.fragment_transaction_list_mint_tx_title
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to customTransactionTitle

package.json Outdated
"react-native-v8": ">=0.59.10-patch.0 <0.59.11",
"react-native-vector-icons": "^6.1.0",
"react-native-webview": "git://github.com/swansontec/react-native-webview#edge-version",
"react-native-zcoin-sigma": "git://github.com/hzak/react-native-zcoin-sigma#860d64c21b8c64b83f6aad50012185d6d3ebced5",
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use zcoin github repo

@hzak hzak force-pushed the integrate-zcoin-sigma branch from 6eec242 to 7c17ab9 Compare July 20, 2020 15:02
@hzak hzak force-pushed the integrate-zcoin-sigma branch 4 times, most recently from fc2e2b2 to 7d9c19c Compare July 30, 2020 10:52
@hzak hzak force-pushed the integrate-zcoin-sigma branch from 7d9c19c to a1cce36 Compare July 31, 2020 10:09
@thehobbit85 thehobbit85 reopened this Jun 10, 2021
@hzak hzak closed this May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants