Skip to content

Abstract L2 #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samholmes merged 1 commit into from
Feb 17, 2025
+19 −0
Merged

Abstract L2 #5446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased (develop)

- added: Add Abstract ETH Layer 2 support

## 4.22.0 (staging)

- added: `NotificationCenterScene`
Expand Down
13 changes: 13 additions & 0 deletions src/constants/WalletAndCurrencyConstants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,19 @@ export const getSpecialCurrencyInfo = (pluginId: string): SpecialCurrencyInfo =>
export const SPECIAL_CURRENCY_INFO: {
[pluginId: string]: SpecialCurrencyInfo
} = {
abstract: {
allowZeroTx: true,
chainCode: 'ETH',
Copy link
Contributor

@swansontec swansontec Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used for FIO. Does FIO support Abstract? If so, is this the code they use?

Copy link
Contributor Author

@samholmes samholmes Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if FIO supports Abstract or not. I copied the chainCode from all the other EVM based SpecialCurrencyInfos. Do these other configs need fixing too?

Copy link
Contributor

@swansontec swansontec Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely you have found a bug!

chainIcon: true,
dummyPublicAddress: '0x0d73358506663d484945ba85d0cd435ad610b0a0',
initWalletName: lstrings.string_first_abstract_wallet_name,
isImportKeySupported: true,
noMaxSpend: true,
walletConnectV2ChainId: {
namespace: 'eip155',
reference: '324'
}
},
amoy: {
allowZeroTx: true,
chainCode: 'ETH',
Expand Down
1 change: 1 addition & 0 deletions src/envConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export const asEnvConfig = asObject({
UNSTOPPABLE_DOMAINS_API_KEY: asNullable(asString),

// Core plugin options:
ABSTRACT_INIT: asCorePluginInit(asEvmApiKeys),
ARBITRUM_INIT: asCorePluginInit(asEvmApiKeys),
AMOY_INIT: asCorePluginInit(asEvmApiKeys),
ALGORAND_INIT: asOptional(asBoolean, true),
Expand Down
1 change: 1 addition & 0 deletions src/locales/en_US.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ const strings = {
string_first_bobevm_wallet_name: 'My BOB',
string_first_algorand_wallet_name: 'My Algorand',
string_first_zksync_wallet_name: 'My zkSync',
string_first_abstract_wallet_name: 'My Abstract',
string_first_sepolia_wallet_name: 'My Sepolia',
my_crypto_wallet_name: 'My %s',
string_help: 'Help',
Expand Down
1 change: 1 addition & 0 deletions src/locales/strings/enUS.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,7 @@
"string_first_bobevm_wallet_name": "My BOB",
"string_first_algorand_wallet_name": "My Algorand",
"string_first_zksync_wallet_name": "My zkSync",
"string_first_abstract_wallet_name": "My Abstract",
"string_first_sepolia_wallet_name": "My Sepolia",
"my_crypto_wallet_name": "My %s",
"string_help": "Help",
Expand Down
1 change: 1 addition & 0 deletions src/util/corePlugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { ENV } from '../env'

export const currencyPlugins: EdgeCorePluginsInit = {
// // edge-currency-accountbased:
abstract: ENV.ABSTRACT_INIT,
algorand: ENV.ALGORAND_INIT,
amoy: ENV.AMOY_INIT,
arbitrum: ENV.ARBITRUM_INIT,
Expand Down
Loading