Skip to content

Correct the displayName in getTxActionDisplayInfo #5448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swansontec merged 1 commit into from
Feb 18, 2025
Merged

Correct the displayName in getTxActionDisplayInfo #5448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- added: Add Abstract ETH Layer 2 support
- changed: Force max unstake on Kiln ETH positions
- fixed: Correct the display name for ETH txs on non-Ethereum chains

## 4.22.0 (staging)

Expand Down
1 change: 1 addition & 0 deletions src/__tests__/components/TransactionListRow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ describe('TransactionListRow', () => {
pluginId: 'bitcoin',
currencyCode: 'BTC',
displayName: 'Bitcoin',
assetDisplayName: 'Bitcoin',
requiredConfirmations: 1,
denominations: [
{ name: 'BTC', multiplier: '100000000', symbol: '₿' },
Expand Down
2 changes: 1 addition & 1 deletion src/actions/CategoriesActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export const getTxActionDisplayInfo = (tx: EdgeTransaction, account: EdgeAccount
const { assetAction, chainAction, chainAssetAction, metadata, savedAction, swapData, tokenId } = tx
const { currencyConfig, currencyInfo } = wallet

const { displayName } = tokenId == null ? currencyInfo : currencyConfig.allTokens[tokenId] ?? { displayName: '' }
const displayName = tokenId == null ? currencyInfo.assetDisplayName : currencyConfig.allTokens[tokenId]?.displayName ?? ''

const action = savedAction ?? chainAction
const assetAct = assetAction ?? chainAssetAction
Expand Down
Loading