Force max unstake on Kiln ETH positions#5453
Merged
Conversation
peachbits
force-pushed
the
matthew/kiln-eth-maxunstake
branch
from
dae74f9 to
cb82451
Compare
swansontec
approved these changes
Feb 17, 2025
peachbits
force-pushed
the
matthew/kiln-eth-maxunstake
branch
from
cb82451 to
8e70201
Compare
peachbits
force-pushed
the
matthew/kiln-eth-maxunstake
branch
from
8e70201 to
f1f98e0
Compare
This is a hack to prevent users from being able to enter a greater amount of LP tokens than they actually have. Since the currency plugins and GUI's stake plugins all still rely on currency code, the actual balance of LP tokens isn't readily available and would recover some hacking to override the balance used in the flip input modal. We're not passing the correct tokenId in anyway so introducing hack in the stake scenes and flip input could just cause more issues.
peachbits
force-pushed
the
matthew/kiln-eth-maxunstake
branch
from
f1f98e0 to
9c6a1c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: