Conversation
…nload limit When downloading individual .yml backup files, all downloads were triggered simultaneously via forEach + link.click(). Chromium blocks rapid programmatic downloads after ~10, causing only model1* files to be saved. Changed to sequential downloads with a 200ms delay between each file. Added test verifying all 43 models are returned correctly.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
+ Coverage 34.95% 35.71% +0.75%
==========================================
Files 115 115
Lines 4288 4281 -7
Branches 1033 1034 +1
==========================================
+ Hits 1499 1529 +30
+ Misses 2585 2542 -43
- Partials 204 210 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As suggested in code review: - Replace manual Blob/link DOM manipulation with legacyDownload (js-file-download) - Use p-limit(5) for concurrency limiting instead of fully sequential reduce chain - Use delay() utility from shared/tools instead of raw setTimeout - Simplify test by mocking legacyDownload directly
…mize Chromium handling
freshollie
left a comment
freshollie
left a comment
There was a problem hiding this comment.
If you tested as working, feel free to merge
…s Chromium's simultaneous download limit
After several tests, I discovered that the batches weren't always running correctly. I've made a small change that seems to be effective; images attached. 
|
…prove test performance
|
Oh btw you could in theory add an e2e for this, but I'm not sure how you setup this sort of test :) |
As I already mentioned, this is a very new stack for me, and I'm doing what I can, XD!! But I'm learning little by little, thanks for your time! |
3 participants
This pull request improves the backup download flow to address issues with downloading a large number of files simultaneously, and adds a test to ensure robust handling of bulk downloads. The main changes are grouped into improvements to the download logic and enhancements to test coverage.
Improvements to backup download logic:
BackupCreateFlow.tsxto download files sequentially with a delay, preventing Chromium's rapid download blocking when many files are downloaded at once. [1] [2]Test coverage enhancements:
backup.spec.tsto verify that downloading a large number of models (e.g., 43) works correctly and all files are present and valid.Bug reported on:
https://discord.com/channels/761870396085108757/854744834698379274/1481212834766655578