Merged
Conversation
rickard-von-essen
force-pushed
the
fix-lang-detect
branch
from
eb3c818 to
363768e
Compare
If the browser reports en-US as the preferred language that was previously disregarded since it doesn't match any translations. This fix strips off the variant, i.e. the part after the dash, so en-US becomes en. Fixes EdgeTX#94
rickard-von-essen
force-pushed
the
fix-lang-detect
branch
from
363768e to
0843671
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
- Coverage 41.44% 41.43% -0.02%
==========================================
Files 103 103
Lines 12010 12013 +3
Branches 521 521
==========================================
Hits 4977 4977
- Misses 7024 7027 +3
Partials 9 9 ☔ View full report in Codecov by Sentry. |
freshollie
approved these changes
Feb 14, 2025
Collaborator
|
Nice, thanks for the fix! |
Member
|
Indeed. Much appreciated! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the browser reports
en-USas the preferred language that was previously disregarded since it doesn't match any translations. This fix strips off the variant, i.e. the part after the dash, soen-USbecomesen.Fixes #94
Also updates dep
i18next-browser-languagedetectorto v 8.0.2