Skip to content

fix: return 404 if job not found #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphaelcoeffic merged 1 commit into from
May 4, 2025
Merged

fix: return 404 if job not found #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (app *Application) getBuildJobLogs(c *gin.Context) {
if logs == nil {
c.AbortWithStatusJSON(
http.StatusNotFound,
NewErrorResponse("Failed to find job"),
NewErrorResponse("job not found"),
)
return
}
Expand Down Expand Up @@ -184,14 +184,14 @@ func (app *Application) buildJobStatus(c *gin.Context) {
return
}
job, err := app.artifactory.GetBuild(req)
if err != nil {
if err != nil && !errors.Is(err, artifactory.ErrBuildNotFound) {
ServiceUnavailableResponse(c, err)
return
}
if job == nil {
c.AbortWithStatusJSON(
http.StatusNotFound,
NewErrorResponse("Failed to find job with requested params"),
NewErrorResponse("no such job"),
)
return
}
Expand Down