suggestion on 'pyproject.toml>dependencies' : add dna_features_viewer#4
Open
ramez17khaled wants to merge 1 commit intoEdinburgh-Genome-Foundry:masterfrom
Open
suggestion on 'pyproject.toml>dependencies' : add dna_features_viewer#4ramez17khaled wants to merge 1 commit intoEdinburgh-Genome-Foundry:masterfrom
ramez17khaled wants to merge 1 commit intoEdinburgh-Genome-Foundry:masterfrom
Conversation
Member
|
Thanks for the contribution. I wouldn't add DFV by default as it's too heavy and not needed for the core functionalities. Crazydoc does handle a missing DFV, but I can make an install extras option ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
dna_features_viewerpackage to the project's dependencies inpyproject.toml.What Changed
"dna_features_viewer"to thecrazydocdependencies list.Why
While preparing a Bioconda recipe for this package, I noticed that
dna_features_vieweris used inplot.py, specifically in theCrazydocSketcherclass, but it was not listed in the dependencies.I suggest adding it to the dependencies list to ensure users installing the package (e.g., via pip or through Bioconda) won’t encounter runtime errors due to missing imports.
Notes
This change helps make the package more robust and easier to integrate into environments like Bioconda or virtualenv setups.