Conversation
…ed two new SCSS files: global.scss and searchWindow.scss.
| .textViewContent h1 { | ||
| font-weight: bold; | ||
| font-size: 2em; | ||
| font-size: 1.3em !important; //coppied from todo.css |
There was a problem hiding this comment.
This does not seem to have an effect... At least it looks different in the new branch...
There was a problem hiding this comment.
textViewContent.scss is commented out in packages/eoTheme/sass/etc/all.scss so the declaration has no effect
daniel-jettka
left a comment
daniel-jettka
left a comment
There was a problem hiding this comment.
I still have the opinion that !important should really only be used in exceptional cases.
The use of !important is more a sign that a CSS selector is maybe not specific enough if it collides with another one.
Thank you, @daniel-jettka. I added |
…dirom/Edirom-Online-Frontend into 99-bug-what-to-do-with-ignored-todocss # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…dirom/Edirom-Online-Frontend into 99-bug-what-to-do-with-ignored-todocss
3 participants
Description, Context and related Issue
This refactoring migrates all CSS rules from todo.css into properly organized SCSS modules within the theme package.
Refs #99
How Has This Been Tested?
Types of changes
Overview