handle executable paths with spaces in CLI arguments, close #5845#5853
Merged
IMax153 merged 2 commits intoEffect-TS:mainfrom Dec 15, 2025
Merged
handle executable paths with spaces in CLI arguments, close #5845#5853IMax153 merged 2 commits intoEffect-TS:mainfrom
IMax153 merged 2 commits intoEffect-TS:mainfrom
Conversation
🦋 Changeset detectedLatest commit: d68996c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMax153
approved these changes
Dec 3, 2025
Member
IMax153
left a comment
IMax153
left a comment
There was a problem hiding this comment.
Going to also add @kitlangton for review here.
Member
|
@kitlangton can you please review? |
kitlangton
approved these changes
Dec 14, 2025
Contributor
kitlangton
left a comment
kitlangton
left a comment
There was a problem hiding this comment.
LGTM @IMax153
Just one tiny nitpick
Merged
Masty88
added a commit
to Masty88/effect
that referenced
this pull request
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Description
Fixes executable path splitting when paths contain spaces (e.g.,
C:\Program Files\nodejs\node.exeon Windows or/usr/local/My Programs/nodeon Unix-like systems).Instead of using
executable.split(/\s+/)which breaks any path with spaces, we now extract runtime and script directly from the original args array usingArr.take(originalArgs, 2).Changes:
handleBuiltInOption()to acceptoriginalArgsparameterSetLogLevelcase to preserve paths with spaces when re-executing commandsShowWizardcase to preserve paths with spaces when running wizard-constructed commandsgetExecutableArgs()to extract runtime and script from original argsCliApp.test.tsTest plan:
npx tsx examples/minigit.ts --log-level info -c test=value clone https://github.com/test/repoRelated