Fix HttpServerResponse.fromWeb losing Content-Type header #5940
+44
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HttpServerResponse.fromWebto preserve theContent-Typeheader when converting a webResponsetoHttpServerResponseBody.stream(), causing it to default toapplication/octet-streamHttpApp.fromWebHandlerto wrap web handlers (e.g., integrating third-party auth libraries like Better Auth)Test Plan
preserves response content-type header- verifies JSON responses have correct content-typepreserves custom content-type header- verifies custom content-types liketext/htmlare preservedjson preserves content-type- verifiestoWebHandlercorrectly outputs content-typeAll 175 tests pass.
Example
Before this fix, wrapping a web handler would lose the Content-Type: