Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-beds-lick.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/eslint-plugin": patch
---

Fix import type \* as ... in barrel import rules
2 changes: 1 addition & 1 deletion src/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const meta = {

export const rules = {
dprint,
noImportFromBarrelPackage,
"no-import-from-barrel-package": noImportFromBarrelPackage,
}

// NOTE: unfortunately plugins needs a self-reference inside configs,
Expand Down
2 changes: 2 additions & 0 deletions src/rules/no-import-from-barrel-package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ export const noImportFromBarrelPackage = createRule<[Options], MessageIds>({
create: (context, options) => {
return {
ImportDeclaration: node => {
// do not check for type imports
if (node.importKind === "type") return
// destruct options
const [{ packageNames }] = options
// first we check if the import is from one of the configured modules
Expand Down
9 changes: 6 additions & 3 deletions test/no-import-from-barrel-package.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,14 @@ import { ruleTester } from "@effect/eslint-plugin/test/utils/index"

const options: [Options] = [{ packageNames: ["effect"] }]

ruleTester.run("dprint", rule, {
ruleTester.run("no-import-from-barrel-package", rule, {
valid: [
{
code: `import * as T from "effect/Effect"`,
options,
},
{
code: `import { Effect as Eff} from "effect/Effect"
`,
code: `import { Effect as Eff} from "effect/Effect"`,
options,
},
{
Expand All @@ -23,6 +22,10 @@ ruleTester.run("dprint", rule, {
code: `import {type Effect } from "effect";`,
options,
},
{
code: `import type { Effect } from "effect"`,
options,
},
{
code: `import {test} from "lodash";`,
options,
Expand Down