update(transformers): general clean up & improvment#12
update(transformers): general clean up & improvment#12ajweeks wants to merge 6 commits intoEffiSciencesResearch:masterfrom
Conversation
ddorn
left a comment
There was a problem hiding this comment.
Thanks for going through the notebook and fixing so many small things. I've added a few comments, because I think a few things can be improved.
You can resolve the comments once you're done, and leave me a message for those you don't agree with and then I'll merge ;)
Also I might have fixed the bug on master that prevented you from running the pre-commit, so you should pull and try again! (so that you don't have to copy paste painfully all your changes...)
|
Updated with your feedback! |
|
How are fixes normally propagated to the arena notebook? |
They aren't, we provide it mostly as-is. I don't think you should propagate them, it's not worth it. |
|
Great, then I think this is ready for merging now :) |
This change fixes typos, unifies variable naming, and improves wording of several sections.
Note that I wasn't able to get the scripts (nor precommit hooks) running on Windows so I have edited each file manually.