Skip to content

update(transformers): general clean up & improvment#12

Open
ajweeks wants to merge 6 commits intoEffiSciencesResearch:masterfrom
ajweeks:patch-1
Open

update(transformers): general clean up & improvment#12
ajweeks wants to merge 6 commits intoEffiSciencesResearch:masterfrom
ajweeks:patch-1

Conversation

@ajweeks
Copy link
Contributor

@ajweeks ajweeks commented Mar 6, 2025

This change fixes typos, unifies variable naming, and improves wording of several sections.

Note that I wasn't able to get the scripts (nor precommit hooks) running on Windows so I have edited each file manually.

Copy link
Collaborator

@ddorn ddorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through the notebook and fixing so many small things. I've added a few comments, because I think a few things can be improved.
You can resolve the comments once you're done, and leave me a message for those you don't agree with and then I'll merge ;)

Also I might have fixed the bug on master that prevented you from running the pre-commit, so you should pull and try again! (so that you don't have to copy paste painfully all your changes...)

@ajweeks
Copy link
Contributor Author

ajweeks commented Mar 29, 2025

Updated with your feedback!

@ajweeks
Copy link
Contributor Author

ajweeks commented Mar 29, 2025

How are fixes normally propagated to the arena notebook?

@ddorn
Copy link
Collaborator

ddorn commented Mar 29, 2025

How are fixes normally propagated to the arena notebook?

They aren't, we provide it mostly as-is. I don't think you should propagate them, it's not worth it.

@ajweeks
Copy link
Contributor Author

ajweeks commented Mar 29, 2025

Great, then I think this is ready for merging now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants