Skip to content

Feedback Forms inherit the access rights from the folder#19

Open
wusche1 wants to merge 2 commits intoEffiSciencesResearch:masterfrom
wusche1:feedback-forms-improvements
Open

Feedback Forms inherit the access rights from the folder#19
wusche1 wants to merge 2 commits intoEffiSciencesResearch:masterfrom
wusche1:feedback-forms-improvements

Conversation

@wusche1
Copy link
Collaborator

@wusche1 wusche1 commented Sep 21, 2025

Feedback Forms inherit the access rights from the folder

- Updated config.yaml with new configurations
- Enhanced main.py with improved functionality
- Modified models.py for better data handling
- Updated utils.py with additional utilities
- Added balloon.png meme resource
- Added .DS_Store and */.DS_Store patterns to prevent macOS system files from being tracked
@ddorn
Copy link
Collaborator

ddorn commented Sep 21, 2025

Thanks, but I'm a little bit confused about this PR.

The forms do seem to already inherit the access from the parent folder (at least when I do it). But if it's not the case, then is should always happen, and not be configurable. Exception handling in this code is quite crazy too, there are three levels of try to silence exceptions, you probably want to tune your llm diferently ;)

Also, I'm thinking that we probably shouldn't commit the config.yaml, especially when multiple camps are run in the same time... but I'm not sure what the best thing to do is here. One extra note is that I've changed the Name to "choice" so that we can much more easily track evolution of participants answer over time, with no worries that they input different names sometimes (which does happen).

Last, I'd rather not add a scale_5_point and scale_1_to_10. I think a single scale type that has configurable bounds is much cleaner.

Btw, you may want to add .DS_Store to the global gitignore of your machine in ~/.config/git/ignore so it's done once and for all ;) https://docs.github.com/en/get-started/git-basics/ignoring-files#configuring-ignored-files-for-all-repositories-on-your-computer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants