π‘οΈ Sentinel: [HIGH] Fix request size limit bypass via chunked transfer encoding - #6317
Conversation
β¦r encoding HTTP requests using chunked transfer encoding bypassed the `content-length` body size limits in the request sanitization middleware. This commit explicitly rejects chunked transfer encoding to prevent resource exhaustion.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the βοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π¨ Severity: HIGHπ‘ Vulnerability: HTTP chunked transfer encoding bypasses the standardcontent-lengthlimit checks since the exact size is not predetermined.π― Impact: Without global body limit support on chunked payloads, it can lead to resource exhaustion (Request Smuggling/DoS). The API requires predetermined length for accurate prompt size validation.π§ Fix: Added a check inrequest_sanitization_middlewareto reject requests containingtransfer-encoding: chunkedwith a411 Length Requiredstatus code.β Verification: Verified compilation and existing test suites pass.PR created automatically by Jules for task 7561371268415162953 started by @EffortlessSteven