Skip to content

Tiny cleanups #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SteveSandersonMS wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tiny cleanups #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06e600b
Avoid needing globally unique IDs for some checkboxes
SteveSandersonMS Oct 17, 2018
1c4cff4
Eliminate redundant attribute
SteveSandersonMS Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/Hubbup.IssueMoverClient/Pages/IssueMover.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
@page "/issuemover"
@using System.Globalization
@using Hubbup.Web.Utils
@using System.Text

@inject AppState State

Expand All @@ -27,7 +26,7 @@
</div>
<div class="col-md-1">
<div class="input-group">
<input type="button" class="btn btn-info @(State.ShouldMoveButtonBeEnabled() ? "" : "disabled")" disabled="@(!State.ShouldMoveButtonBeEnabled())" value="Go" onclick="@State.OnMoveButtonClick" />
<input type="button" class="btn btn-info" disabled="@(!State.ShouldMoveButtonBeEnabled())" value="Go" onclick="@State.OnMoveButtonClick" />
Copy link
Owner

@Eilon Eilon Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Bootstrap don't I need the disabled CSS class also applied?

Copy link
Contributor Author

@SteveSandersonMS SteveSandersonMS Oct 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe you do. If so please ignore and close this.

I tried it and as far as I remember it looked correctly disabled without repeating that info in the CSS class, but maybe there was something more subtle in the styling that I missed.

</div>
</div>
</div>
Expand All @@ -37,14 +36,14 @@
Options:
<ul>
<li>
<input type="checkbox" id="moveIssueCheckBox" checked="checked" disabled="disabled" /> <label for="moveIssueCheckBox">Move issue</label>
<label><input type="checkbox" checked="checked" disabled="disabled" /> Move issue</label>
@if (State.OriginalIssueMoveData != null)
{
<div><a href="@State.OriginalIssueMoveData.HtmlUrl">#@State.OriginalIssueMoveData.Number @State.OriginalIssueMoveData.Title</a></div>
}
</li>
<li>
<input type="checkbox" id="createLabelsCheckBox" bind="@State.ShouldCreateDestinationLabels" /> <label for="createLabelsCheckBox">Create destination labels (if needed)</label>
<label><input type="checkbox" bind="@State.ShouldCreateDestinationLabels" /> Create destination labels (if needed)</label>
<div>
@if (State.OriginalIssueMoveData?.Labels.Any() == true)
{
Expand All @@ -57,16 +56,16 @@
</div>
</li>
<li>
<input type="checkbox" id="createMilestoneCheckBox" bind="@State.ShouldCreateDestinationMilestone" /> <label for="createMilestoneCheckBox">Create destination milestone (if needed)</label>
<label><input type="checkbox" bind="@State.ShouldCreateDestinationMilestone" /> Create destination milestone (if needed)</label>
<div>@State.OriginalIssueMoveData?.Milestone</div>
</li>
<li>
<input type="checkbox" id="moveCommentsCheckBox" checked="checked" disabled="disabled" /> <label for="moveCommentsCheckBox">Move comments</label>
<label><input type="checkbox" checked="checked" disabled="disabled" /> Move comments</label>
<div><span class="glyphicon glyphicon-comment" aria-hidden="true"></span> @State.OriginalIssueMoveData?.Comments.Count.ToString(CultureInfo.InvariantCulture) comment(s)</div>
</li>
<li><input type="checkbox" id="addCloseMessageCheckBox" checked="checked" disabled="disabled" /> <label for="addCloseMessageCheckBox">Add close message to original issue</label></li>
<li><input type="checkbox" id="lockOriginalIssueCheckBox" bind="@State.ShouldLockOriginalIssue" /> <label for="lockOriginalIssueCheckBox">Lock original issue</label></li>
<li><input type="checkbox" id="closeOriginalIssueCheckBox" checked="checked" disabled="disabled" /> <label for="closeOriginalIssueCheckBox">Close original issue</label></li>
<li><label><input type="checkbox" checked="checked" disabled="disabled" /> Add close message to original issue</label></li>
<li><label><input type="checkbox" bind="@State.ShouldLockOriginalIssue" /> Lock original issue</label></li>
<li><label><input type="checkbox" checked="checked" disabled="disabled" /> Close original issue</label></li>
</ul>
</div>

Expand Down