-
Notifications
You must be signed in to change notification settings - Fork 3
NDT 3D demo #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NDT 3D demo #12
Conversation
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
| ), | ||
| launch_arguments={'world_name': 'magazino_hallway.world'}.items(), | ||
| ), | ||
| Node( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe you can use https://github.com/ekumenlabs/kobuki_ros2_stack/blob/main/bringup/gonbuki_bringup_common/launch/bringup_launch.py and don't include many of the nodes here (teleop, rviz, simulation, spawn)
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
hidmic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass
localization/beluga_demo_ndt_3d_localization/scripts/generate_random_vertices.py
Show resolved
Hide resolved
| PythonLaunchDescriptionSource( | ||
| PathJoinSubstitution( | ||
| [ | ||
| FindPackageShare("beluga_example"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fernando-Sanz meta: hmm, I'm not super fond of (re)using beluga_example here. It's a leaf package we don't release and we are making use of utility launch files that could go away the next refactor.
| [ | ||
| FindPackageShare("gonbuki_description"), | ||
| "launch", | ||
| "robot_description.launch.py", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fernando-Sanz FYI the local simulation in this repository should cover your use case. Same world, same robot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used the launch file in gonbuki_bringup_simulation_stack, is that the file you are referring to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the beluga_demo_gazebo stack in this very same repository. Just FYI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, using gonbuki_bringup_simulation_stack sounds like a good idea.
We're using that robot for this demo anyway.
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
hidmic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to test this next.
| @@ -0,0 +1,30 @@ | |||
| # Copyright 2023-2024 Ekumen, Inc. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fernando-Sanz nit: dates need an update, I think. Here and elsewhere in this patch.
Signed-off-by: Fer <[email protected]>
Signed-off-by: Fer <[email protected]>
Proposed changes
Add simple demo with Beluga using NDT 3D in localization process.
ndt.mp4
Type of change
Checklist