Skip to content

Conversation

@Fernando-Sanz
Copy link

@Fernando-Sanz Fernando-Sanz commented Feb 14, 2025

Proposed changes

Add simple demo with Beluga using NDT 3D in localization process.

ndt.mp4

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

Checklist

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

),
launch_arguments={'world_name': 'magazino_hallway.world'}.items(),
),
Node(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you can use https://github.com/ekumenlabs/kobuki_ros2_stack/blob/main/bringup/gonbuki_bringup_common/launch/bringup_launch.py and don't include many of the nodes here (teleop, rviz, simulation, spawn)

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

PythonLaunchDescriptionSource(
PathJoinSubstitution(
[
FindPackageShare("beluga_example"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fernando-Sanz meta: hmm, I'm not super fond of (re)using beluga_example here. It's a leaf package we don't release and we are making use of utility launch files that could go away the next refactor.

[
FindPackageShare("gonbuki_description"),
"launch",
"robot_description.launch.py",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fernando-Sanz FYI the local simulation in this repository should cover your use case. Same world, same robot.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used the launch file in gonbuki_bringup_simulation_stack, is that the file you are referring to?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the beluga_demo_gazebo stack in this very same repository. Just FYI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, using gonbuki_bringup_simulation_stack sounds like a good idea.
We're using that robot for this demo anyway.

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to test this next.

@@ -0,0 +1,30 @@
# Copyright 2023-2024 Ekumen, Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fernando-Sanz nit: dates need an update, I think. Here and elsewhere in this patch.

Signed-off-by: Fer <[email protected]>
@Fernando-Sanz Fernando-Sanz requested a review from hidmic February 25, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants