Conversation
…pdates Upgraded to vite v6.0.11 (pinned) vitest to latest with the same pinned vite sub-dep @antfu/eslint-config and other eslint plugins required update to avoid peer dependency warnings Turned off new eslint rules (cleanup later along with all the other escaped rules) Upgraded svelte@5 along with it's vite plugin v4 Disable prettier linting to avoid formatting in local envn by prettier vs code extn
… had empty site.ts
… using public folder
…m app-*.css to user-app-*.css
…is now purely iles.config.ts related
…s config, docs updated
… within logic folder
…mposables within logic folder Renamed NavBarLinks.svelte to vue file to avoid (for now) svelte's `lifecycle_function_unavailable`
… auto-suspense test: 🧪 Regenerated snapshots to baseline the following changes - Suspense boundary related asset naming change from default-*.css to Island-*.css - New /cat-zone route - NavBarLinks.vue with the new link to /cat-zone
…w better and slimmer sidebar
|
View your CI Pipeline Execution ↗ for commit 661e9c0.
☁️ Nx Cloud last updated this comment at |
Deploying iles with
|
| Latest commit: |
661e9c0
|
| Status: | 🚫 Build failed. |
|
That looks like a monster PR. Wouldn't smaller more incremental changes be preferable? |
Collaborator
Author
|
Thanks for your feedback @dagnelies, it's a fair point. I have been working on these commits for a long time and I have been having trouble creating disjoint PRs. @ElMassimo, please advise if you prefer disjoint PRs for your review and I will spend effort to achieving the same. Meanwhile, I have the docs update for all the commits in this PR deployed temporarily at https://iles.netlify.app/recipes for an easy read to feel the flow. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
nextbranch covers:propertytoname, fixes Twitter meta tags #264.default.vuelayout is optional (basic iles app errors out during development ifdefault.vuewas deleted).app.tsandsite.tsoptional, so users can simply add Îles to their existing project (easy onboarding).useSeoMetafrom@unhead/vue, docs updated.index.htmlshell, resolves Ability to customise base HTMLindex.html#136 , Addin Vue UI libraries to iles #271 , Download js/css from cdn only when progressively hydrating a component (client:visible) #267enhanceIslandsAPI for Vue Islands, delivers [Feature Request] - A newenhanceIslandshook to add plugins and other setup to Islands #277 , supersedes feat: enhance-islands API #282unplugin-auto-import, docs and blog updated to use it, delivers Ship unplugin-auto-import with vue & vue-router presets #243 , supersedes refactor: useunplugin-auto-import#199CatDisplay.vuein the blog to illustrate, supersedes feat: make top-level await vue islands possible #178Static Assetspage.Screenshots:
Use default title & description when user has an empty
site.ts.Before:
After:
