feat: add support for json and jsonb fields #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for json and jsonb fields, converting them to
Record<string, any>in the Typescript types.This might be worth a discussion, since Typescript conventions would dictate that a more appropriate type is
Record<string, unknown>, given thatanyis seen as a code smell. However, making itRecord<string, unknown>would have the effect of forcing you to override the library's type conversion, by either specifyingRecord<string, any>or by writing a more comprehensive type, which defeats the purpose of automatic conversion.A stronger alternative would be something like
JSONObject:But that seems like a fairly large departure from the current approach of fairly straightforward type conversion.