Skip to content

Add PHPStan#195

Draft
IonBazan wants to merge 2 commits intoElao:2.xfrom
IonBazan:feature/phpstan
Draft

Add PHPStan#195
IonBazan wants to merge 2 commits intoElao:2.xfrom
IonBazan:feature/phpstan

Conversation

@IonBazan
Copy link
Copy Markdown
Contributor

This PR attempts to add PHPStan analysis to CI process.

Changes include:

  • Using phpunit/phpunit to make it easier for PHPStan to discover its classes (symfony/phpunit-bridge no longer conflicts with it)
  • Add some missing return types (this could potentially be a BC break if someone extends one of these classes and uses different return type)

To do:

  • Add missing iterable types
  • Resolve templates issues (shadowing, etc)
  • Add more missing types

@ogizanagi ogizanagi added this to the 2.x milestone Jun 20, 2022
@ogizanagi ogizanagi linked an issue Jun 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Introduce a Psalm/PhpStan check

2 participants