Address dangerous GPlate default in Plated typeclass#58
Draft
Address dangerous GPlate default in Plated typeclass#58
Conversation
- Add explicit Plated instance for Constraint loc - Improve documentation with warnings about GPlate dangers - Remove TODO comment and address the safety concern Co-authored-by: bristermitten <18754735+bristermitten@users.noreply.github.com>
Add clarifying comments explaining that the GPlate-based fallback instances in DataPlated.hs are intentional and rely on type-system enforced Generic instances for AST types. Co-authored-by: bristermitten <18754735+bristermitten@users.noreply.github.com>
Add a clear example showing how a type without Generic would be silently skipped during traversal. Clarify that Generic refers to GHC.Generics.Generic. Co-authored-by: bristermitten <18754735+bristermitten@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix dangerous function for generic instances in Prelude
Address dangerous GPlate default in Plated typeclass
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Platedtypeclass's default implementation usingGPlatesilently ignores fields withoutGenericinstances, causing incomplete traversals with no compiler warning.Changes
Constraint locinstance explicit - The only production instance relying on the unsafe default now has manual pattern matching that explicitly handles all constructorsGenericrefers toGHC.Generics.GenericDataPlated.hsare intentional and type-safe by designExample of the danger
All 9
Platedinstances in the codebase are now either explicit or documented as intentionally using GPlate.Original prompt
Created from VS Code via the GitHub Pull Request extension.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.