This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Change the way the allow and deny list is handled.#62
Open
JanFellner wants to merge 1 commit intoElders:masterfrom
Open
Change the way the allow and deny list is handled.#62JanFellner wants to merge 1 commit intoElders:masterfrom
JanFellner wants to merge 1 commit intoElders:masterfrom
Conversation
A file needs to be in the allow list but not in the deny list to get formatted
Contributor
|
10x for this PR. Any idea how to handle existing user settings? Users may have configured settings in .config file or in the VS settings. If we do apply this PR directly, would it break their setup? I think so. May be we can add a boolean flag which states Just thinking out loud... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really like your extension but the idea how allowed and denied list is handled (interpreted) is kind of wieeerd :) to me.
I don´t know any system that does it the way the extension does it.
In general speaking i would assume something needs to be in the allowed list to get formatted at all and there may be exclusion from that allowed list. Furthermore i also allow filenames to be part in that list instead of just extensions.
Thus the concept of this PR ist.
Especially if i would generally like to get .h files formatted but e.g. not resource.h files which are written by the ide.
This PR solves that issue (or missing functionality)