Fix CUDA extension compilation and CPU fallback logic#5
Fix CUDA extension compilation and CPU fallback logic#5Electroiscoding wants to merge 1 commit intomainfrom
Conversation
- Relaxed `CUDA_HOME` requirement in `setup.py` to allow compilation if `nvcc` is available in `PATH`. - Fixed unused variable `node` in `gpu_engine_cuda.cu`. - Properly catch `"No CUDA devices found"` error in `vocabulary.py` to trigger CPU fallback properly. - Updated `is_cuda_available()` in `__init__.py` to correctly evaluate `"No CUDA devices found"` response. Co-authored-by: Electroiscoding <103299713+Electroiscoding@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes several issues related to the CUDA extension:
CUDA_HOMErequirement insetup.pyto allow the CUDA extension to compile as long asnvccis available, addressing environments where PyTorch orCUDA_HOMEis partially set up.tokenize_kernelinsidegpu_engine_cuda.cuto prevent compilation warnings/errors.vocabulary.pyto appropriately trigger the CPU fallback if the CUDA backend initialized but found no hardware, preventing runtime errors later.is_cuda_available()method inc_ext/__init__.pyto accurately reflect a lack of CUDA hardware, setting_cuda_errorinstead of silently claiming availability.PR created automatically by Jules for task 2234727710909910041 started by @Electroiscoding