Conversation
Co-authored-by: Mopsior <https://github.com/Mopsior>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
konhi
left a comment
konhi
left a comment
There was a problem hiding this comment.
few minor changes, but besides, a great job 🔥
you should focus on writting good content though, it's far more important than pretty designs; i.e. lorem ipsum and other fillers suck on fat dick
features/landing-page/Footer.tsx
Outdated
| max-[768px]:flex-col | ||
| max-[768px]:items-center | ||
| max-[768px]:justify-even | ||
| max-[768px]:h-[300px]"> |
There was a problem hiding this comment.
why not media queries? md: = 768px
https://tailwindcss.com/docs/responsive-design
features/landing-page/Footer.tsx
Outdated
| max-[768px]:justify-even | ||
| max-[768px]:h-[300px]"> | ||
| <p | ||
| className="text-[24px] |
There was a problem hiding this comment.
i think you're overrusing arbitrary values in few places
why not use text-2xl?
| 'blackpule': "#000212", | ||
| 'graypule': "#090B1D", |
pages/index.tsx
Outdated
| import Navbar from "features/landing-page/Navbar"; | ||
| import Main from "features/landing-page/Main"; | ||
| import Footer from "features/landing-page/Footer"; | ||
| import { ClassNames } from "@emotion/react"; |
pages/index.tsx
Outdated
| import { ClassNames } from "@emotion/react"; | ||
|
|
||
| export default function HomePage() { | ||
| export default function HomePage(): JSX.Element { |
package.json
Outdated
| "@emotion/react": "^11.10.5", | ||
| "@emotion/styled": "^11.10.5", |
There was a problem hiding this comment.
won't this work without emotion? :( i'd generally encourage to use material icon variable font, because we're adding 3 unnecessary packages just for icons
| <button onClick={() => setOpenLogin(false)}>X</button> | ||
| </> | ||
| : <div> | ||
| <button |
There was a problem hiding this comment.
maybe it makes sense to use Button component? if the styles don't match, create a new variant
this applies to few places in code
features/landing-page/Navbar.tsx
Outdated
| <li className="cursor-pointer">{t("contact")}</li> | ||
| <li className="cursor-pointer">{t("team")}</li> |
There was a problem hiding this comment.
doesn't make sense to add cursor-pointer as class
just make it a link with <Link href="#"
probably applies to few places in code
features/landing-page/Navbar.tsx
Outdated
| import { useState } from "react" | ||
| import { useTranslation } from "next-i18next"; | ||
|
|
||
| export default function Navbar() { |
There was a problem hiding this comment.
- default exports are a bad practice and shouldn't be used (nextjs pages are a a exception)
- please use
const = () =>instead offunction, it's generally a convention to do so in react codebases
Co-authored-by: Jan Szymański <hello.konhi@gmail.com>
Page title from translations
3 participants
Check please, buziaki <3