Pre-taproot elements updates #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
force-pushed
the
pre_taproot_elements_updates
branch
4 times, most recently
from
3ccb18c to
7bf9588
Compare
- Run CI tests with/without Elements, also test minimal build as used by Jade - Enable -Werror for the main test run - Fail if scan-build errors are detected - Expose scan-build artifacts for investigating reported errors - Do not build release files if any tests fail
This is the same size as WALLY_TX_ASSET_TAG_LEN but doesn't give the incorrect impression that these fields hold asset tags.
Elements uses a different tagged hash for tweaking the internal key.
jgriffiths
force-pushed
the
pre_taproot_elements_updates
branch
from
7bf9588 to
83121e1
Compare
Elements core supports standard descriptors but generates (at least for taproot) different scriptpubkeys/addresses since it uses a different hash to tweak its internal keys. Allow specifying that a descriptor is an Elements descriptor when parsing, and use this to perform the correct tweak. Its unclear whether other descriptor expressions are affected since there is no documentation of this behaviour. Elements (only via rust-elements) also supports a renamed set of descriptors and extensions which we do not attempt to support in this change.
Avoids a warning when building.
jgriffiths
force-pushed
the
pre_taproot_elements_updates
branch
from
83121e1 to
088e3f8
Compare
For use by a later commit.
The Elements case is more complicated and will be computed in its own function.
We don't use this yet, but taproot requires it.
jgriffiths
force-pushed
the
pre_taproot_elements_updates
branch
from
c8c2327 to
6998c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc updates prior to implementing taproot for Elements.