Update pre-segwit signature hashing to use the new caching implementation #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pre-segwit hashing requires these so split them out for re-use.
jgriffiths
force-pushed
the
signature_hash_pre_segwit
branch
from
fe1aa4a to
afa8167
Compare
jgriffiths
changed the title
Caching is not possible for pre-segwit txs since there are no sub-hashes used in signature hash generation. We get the other benefits of the new impl by migrating though - i.e. reduced stack/memory use, faster hashing and clearer/more consistent code.
…hashes Now that signature hashes are generated by tx_io, this logic can be reverted to just the tx serialization.
jgriffiths
force-pushed
the
signature_hash_pre_segwit
branch
from
f0bbe7a to
139bc54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes moving signature hash generation to the new, caching interface. Although pre-segwit transactions do not benefit from caching, the new impl is cleaner and uses less stack. Additionally, it allows removing all signature hash generation code from the transaction serialization code, making it easier to reason about.