new notifications: plugin_stopped and plugin_started
#7508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
reviewed
Jul 31, 2024
gudnuf
force-pushed
the
plugin_stop_start_notifications
branch
from
bb2399f to
af35c0c
Compare
Member
|
ACK af35c0c |
cdecker
force-pushed
the
plugin_stop_start_notifications
branch
from
af35c0c to
5e9ec0e
Compare
Member
|
Picking this up again, as it bitrotted away a bit. |
rustyrussell
force-pushed
the
plugin_stop_start_notifications
branch
from
5e9ec0e to
f9117dd
Compare
Contributor
|
Rebased, added Changelog-Added line, added "v25.02 onward" to docs. |
[Added version tag into documentation, to show it was added in 25.02 --RR] Changelog-Added: Plugins: new nofitications `plugin_stopped` and `plugin_started`
rustyrussell
force-pushed
the
plugin_stop_start_notifications
branch
from
f9117dd to
2226e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send
plugin_startedwhen a plugin has completed startup and sendplugin_stoppedwhen a plugin is shutdown.This PR follows the same motivations as #7507, and is the second piece of what will be required for other plugins such as clnrest to dynamically register and drop routes.
What's changed?
Added two new notifications:
plugin_startedandplugin_stoppedUpdated the docs with the schemas for these notifications