Bolt updates v24.11 #7586
Merged
Bolt updates v24.11 #7586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
reviewed
Sep 9, 2024
Collaborator
niftynei
left a comment
niftynei
left a comment
There was a problem hiding this comment.
cACK pending test run success
rustyrussell
force-pushed
the
guilt/bolt-updates-v24.11
branch
from
2eeffcf to
b4495b7
Compare
Contributor
Author
|
Trivial rebase... |
rustyrussell
force-pushed
the
guilt/bolt-updates-v24.11
branch
3 times, most recently
from
63a5072 to
8642769
Compare
rustyrussell
force-pushed
the
guilt/bolt-updates-v24.11
branch
from
8642769 to
6a863fb
Compare
We build with this: it changes the blinded_path field to sciddir_or_pubkey. But it wasn't committed, so if someone rebuilt the wire files they'd be wrong. Signed-off-by: Rusty Russell <[email protected]>
This means we should support it by default. Signed-off-by: Rusty Russell <[email protected]> Changelog-Added: Protocol: `option_quiesce` enabled by default. Changelog-Deprecated: Config: --experimental-quiesce: it's now the default.
…ions". Not much difference for us. Signed-off-by: Rusty Russell <[email protected]>
This is obsolete (since modern onions) and so removed from spec. We should not set it, and don't need to handle it specially. Signed-off-by: Rusty Russell <[email protected]>
No code changes, just catching up with the BOLT changes which rework our blinded path terminology (for the better!). Another patch will sweep the rest of our internal names, this tries only to make things compile and fix up the BOLT quotes. 1. Inside payload: current_blinding_point -> current_path_key 2. Inside update_add_htlc TLV: blinding_point -> blinded_path 3. Inside blinded_path: blinding -> first_path_key 4. Inside onion_message: blinding -> path_key. 5. Inside encrypted_data_tlv: next_blinding_override -> next_path_key_override Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `decode` now used modern BOLT 4 language for blinded paths, `first_path_key`. Changelog-Deprecated: JSON-RPC: `decode` `blinding` in blinded path: use `first_path_key`. Changelog-Added: Plugins: `onion_message_recv` and `onion_message_recv_secret` hooks now used modern BOLT 4 language for blinded paths, `first_path_key`. Changelog-Deprecated: JSON-RPC: `onion_message_recv` and `onion_message_recv_secret` hooks `blinding` in blinded path: use `first_path_key`.
It's not documented, and only used internally, so we don't need a deprecation cycle. Signed-off-by: Rusty Russell <[email protected]>
It's not documented, and only used internally, so we don't need a deprecation cycle. Signed-off-by: Rusty Russell <[email protected]>
Get with the modern nomenclature: the pubkey inside a blinded path is called the `path_key` now. Signed-off-by: Rusty Russell <[email protected]>
This is a significant rework, which lets us clarify a number of our quotes. Signed-off-by: Rusty Russell <[email protected]>
…h_hop`") Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/bolt-updates-v24.11
branch
from
6a863fb to
edcae47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly the changes for onion messages and blinded paths, but some other nice things in there too.