Renepay refactor #7588
Closed
Renepay refactor #7588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory we should not have htlc_total<=known_max. But for some strange race condition we do sometimes. Until we find a solution to ensure the correct state of the uncertainty network we remove the assertion. Thanks to signed arithmetic and MIN guards, the rest of the code in linearize_channel can handle the weird cases with known_max<htlc_total. Signed-off-by: Lagrang3 <[email protected]>
- add more checks - add more error messages - compute probabilities without fees during MCF - compute probabilities with fees during get_routes Signed-off-by: Lagrang3 <[email protected]>
Instead of a global variable for plugin data, retrieve plugin data using libplugin API plugin_get_data. Signed-off-by: Lagrang3 <[email protected]>
Contributor
|
This is draft, so removing milestone |
Collaborator
Author
|
This is no longer needed after #8049. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a global variable for plugin data, retrieve plugin data using
libplugin API plugin_get_data.
builds on top of #7574.