Adding askrene-disable-channel #7693
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can think of a way to effectively disable a channel in
askrene: by callingaskrene-inform-channeland set themaximum_msatto 0. But it seems like a workaround way. I think since we already have anaskrene-disable-nodecommand, we should alsosupport an
askrene-disable-channelcommand as well.I have also refactored the way channels are marked as disabled.
Previously we had disabled channels by using
gossmap_local_updatechancall which would produce a plugin crashwhen calling
getroutesif we disable a channel that either doesn't exist or it is defined in a layer that we don't usein that call. Now instead we build a bitmap of disabled channels that we pass on to the MCF solver. The bitmap uses the indexes of the channels relative to the final gossmap, ie. the public gossip plus all localmods coming from the layers.