Skip to content

gossipd: Correct evaluation of new channel announcement timestsamp #7745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024
Merged

gossipd: Correct evaluation of new channel announcement timestsamp #7745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gossipd/gossmap_manage.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ void gossmap_manage_handle_get_txout_reply(struct gossmap_manage *gm, const u8 *

pca = map_del(&gm->pending_ann_map, scid);
if (!pca) {
/* If we looking specifically for this, we no longer
/* If we were looking specifically for this, we no longer
* are (but don't penalize sender: we don't know if it was
* good or bad). */
remove_unknown_scid(gm->daemon->seeker, &scid, true);
Expand Down Expand Up @@ -703,7 +703,7 @@ void gossmap_manage_handle_get_txout_reply(struct gossmap_manage *gm, const u8 *
txout_failures_add(gm->txf, scid);
out:
tal_free(pca);
/* If we looking specifically for this, we no longer are. */
/* If we were looking specifically for this, we no longer are. */
remove_unknown_scid(gm->daemon->seeker, &scid, false);
}

Expand Down Expand Up @@ -773,7 +773,7 @@ static const char *process_channel_update(const tal_t *ctx,
} else {
/* Is this the first update in either direction? If so,
* rewrite channel_announcement so timestamp is correct. */
if (!gossmap_chan_set(chan, dir))
if (!gossmap_chan_set(chan, !dir))
gossip_store_set_timestamp(gm->daemon->gs, chan->cann_off, timestamp);
}

Expand Down
Loading